WIP: Add Serialize/Deserialize for ActiveValue #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Serialize/Deserialize for ActiveValue behind the "with-json" feature flag
videobitva
changed the title
|
What's the current status of this PR? It looks like exactly what I need. I'm happy to push it over the finish line as well |
tyt2y3
reviewed
Nov 28, 2023
| @@ -36,6 +38,7 @@ pub use ActiveValue::NotSet; | |||
| /// ); | |||
| /// ``` | |||
| #[derive(Clone, Debug)] | |||
| #[cfg_attr(feature = "with-json", derive(Serialize, Deserialize))] | |||
There was a problem hiding this comment.
We can use sea_query's value_to_json to handle the Serialize part, but in general ActiveValue does not seem to lend itself for Deserialize, because the trait bound only requires T -> Value.
|
Thank you for the contribution! Do you really needed May be also add some test cases under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Serialize/Deserialize for ActiveValue
PR Info
As of right now there exists "with-json" feature flag, which allows applying changes to an ActiveModel through the JSON Value type. This could be useful when updating some data in the database by sending a JSON to the server through an HTTP API. An alternative way of doing the same thing would be to send the ActiveModel, with all its changes relative tp the Model, directly to the server. This requires the serialization of the ActiveModel. At the moment (sea-orm version 0.11) it is not possible due to Serialize/Deserialize traits not being implemented for ActiveValue. This PR adds the derive for these traits conditionally when the "with-json" feature is enabled. This way the Serialize/Deserialize traits implementation for the exact ActiveModel could be done by the library user, while the implementation for the ActiveValue is behind the feature flag.
New Features
Breaking Changes
Changes